Repository navigation
benchmark: fix hideStackFrames error benchmarks - #66723
Merged
nodejs-github-bot merged 1 commit intoOct 16, 2026
Merged
nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
benchmark
H4ad
approved these changes
Oct 14, 2026
RafaelGSS
added
the
author ready
lpinca
approved these changes
Oct 14, 2026
RafaelGSS
added
the
commit-queue
Collaborator
|
Landed in 2d908f4 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark: fix hideStackFrames error benchmarks
The benchmarks compared
typeagainst'hide-stackframe'while the configured value is'hide-stackframes', so both variants always ran the plain function. They also usedHideStackFrameError, which does not exist; the property isHideStackFramesError.